Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GroupInput is wrong type. #36

Open
darksnow opened this issue Jan 31, 2024 · 2 comments
Open

GroupInput is wrong type. #36

darksnow opened this issue Jan 31, 2024 · 2 comments
Labels
good first issue Good for newcomers

Comments

@darksnow
Copy link

I was trying to use AddGroupToProject and I think I've found a discrepancy.

type ProjectGroupsInput{} takes a ProjectInput{} which takes a uint Id along with the project name.

It also gets an array of GroupInput. which is an alias for ProjectInput so takes the same Id and Name.

However a group id is not a uint, it's a uuid.Uuid in type Group{}

So, my question is, do we need the Name at all if we have the Id for both ProjectInput and GroupInput? More importantly, should we have a new type:

 type GroupInput struct {
   Id *uuid.Uuid,
   Name string,
 }
@shreddedbacon
Copy link
Member

Yeah, seems like it is a discrepancy. But you can use it now if you use the name only when interacting with groups. You don't need to provide both fields in the input

@darksnow
Copy link
Author

darksnow commented Feb 1, 2024

Thanks for that. I was able to use AddGroupToProject() using the group name without the ID.

@shreddedbacon shreddedbacon added the good first issue Good for newcomers label Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants