-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add sphinxcontrib.jquery as a dependency #10
base: main
Are you sure you want to change the base?
Conversation
Thanks for the PR. I think we also need to activate the extension in the There is a mechanism inside Sphinx, which allows extensions to be based on other extensions, so that they get activated automatically. I think we should integrate the usage of this mechanism into this PR as well, then the user doesn't need to do anything else as simply installing our extension. |
Hi @danwos Thanks for the review. I updated the PR. Is the new commit what you meant? |
Sorry, not really. extensions = [
"sphinx_data_viewer",
"sphinxcontrib.jquery"
] And I guess a lot of users may miss this step. |
@danwos Thanks! Keep me posted on that. |
Finally found some time and even better the Sphinx function to load other extensions. I hope we can call it in the setup_extension("sphinxcontrib.jquery") I hope this does the trick without adding it to the user's @jgarte: Do you find some time to add this to your PR? |
Help needed here? As this is blocking #12 |
Hi, this PR intends to resolve #6.