Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should it be mentioned somewhere that jquery is required to be installed for this to be used? #6

Open
jgarte opened this issue Jan 27, 2023 · 4 comments · May be fixed by #10
Open

Should it be mentioned somewhere that jquery is required to be installed for this to be used? #6

jgarte opened this issue Jan 27, 2023 · 4 comments · May be fixed by #10

Comments

@jgarte
Copy link

jgarte commented Jan 27, 2023 •
edited
Loading

Hi,

Should it be mentioned somewhere that jquery is required to be installed for this to be used?

What do you think of rewriting the jquery part in vanilla js? Or, too much work?
@jdillard
Copy link
Contributor

jdillard commented Feb 9, 2023

This might be related to the removal of jQuery in Sphinx 6. It contains instructions for package maintainers.

@danwos
Copy link
Member

danwos commented Feb 10, 2023

I personal have not the time and especially the skills to rewrite it in a clean way.

However there is a jQuery sphinx Extension, which we should add as dependency to get it work again.

@jgarte
Copy link
Author

jgarte commented Feb 10, 2023

Ideally it would be written in vanilla js but I realize that this would be a tall ask.

However there is a jQuery sphinx Extension, which we should add as dependency to get it work again.

What's required in order to add the jquery sphinx extension to useblocks?

@danwos
Copy link
Member

danwos commented Feb 10, 2023

What's required in order to add the jquery sphinx extension to useblocks?
Not sure what you mean...

But however, we simply can use this one to get jquery back: https://github.com/sphinx-contrib/jquery

@jgarte jgarte linked a pull request Mar 10, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add sphinxcontrib.jquery as a dependency jgarte/sphinx-data-viewer
3 participants
@danwos @jdillard @jgarte