task: Pin golang-ci-lint to non-broken version #92
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
golangci-lint
introduced an issue in v1.56 which causes our linter workflow to fail with the following:level=error msg="Running error: can't run linter goanalysis_metalinter\nthe_only_name: cannot find rule: enforce-repeated-arg-type-style"
This will likely be fixed in a v1.56.1 release of the tool soon. And, there is a documented work-around that each project can adopt in their
.golangci.yaml
file. However, to unblock everyone at once, the best option, I think, is to pin us to the previous release.We should be aware that we don't get too far behind on versions though!
Note, per the action docs, a version identifier of just major/minor is acceptable when using the
binary
install option. That's the default so this should be fine (with thegoinstall
install mode then the revision is required as well)