Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

task: Pin golang-ci-lint to non-broken version #92

Merged
merged 1 commit into from
Feb 8, 2024
Merged

Conversation

hyrmn
Copy link
Contributor

@hyrmn hyrmn commented Feb 8, 2024

golangci-lint introduced an issue in v1.56 which causes our linter workflow to fail with the following:

level=error msg="Running error: can't run linter goanalysis_metalinter\nthe_only_name: cannot find rule: enforce-repeated-arg-type-style"

This will likely be fixed in a v1.56.1 release of the tool soon. And, there is a documented work-around that each project can adopt in their .golangci.yaml file. However, to unblock everyone at once, the best option, I think, is to pin us to the previous release.

We should be aware that we don't get too far behind on versions though!

Note, per the action docs, a version identifier of just major/minor is acceptable when using the binary install option. That's the default so this should be fine (with the goinstall install mode then the revision is required as well)

@hyrmn hyrmn self-assigned this Feb 8, 2024
@felipeumpierre felipeumpierre requested a review from a team February 8, 2024 10:32
@hyrmn hyrmn merged commit 53189a0 into main Feb 8, 2024
@hyrmn hyrmn deleted the bh/pin-golangci-lint branch February 8, 2024 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants