Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Be explicit about which generation we're working with in the code #504

Open
vtnate opened this issue Nov 4, 2022 · 0 comments
Open

Be explicit about which generation we're working with in the code #504

vtnate opened this issue Nov 4, 2022 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@vtnate
Copy link
Contributor

vtnate commented Nov 4, 2022

Expected Behavior

We now have models that will only work with a given generation of district system. We should arrange the file structure to make it clear which are shared and which belong to a specific district system.

Be explicit about which generation we're working with here. Should be explicit if statements, or if/when we use minimum python 3.10 we could use a case statement.

We should also improve the folder structure where models that only apply to a give generation of district are clearly separated out.

Actual Behavior

4G is assumed, not explicitly stated, in the else statement

Steps to Reproduce

Version Information

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Todo
Development

No branches or pull requests

1 participant