Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Configure repo with release please and publish docker images #25

Merged
merged 6 commits into from
Nov 21, 2024
Merged

Configure repo with release please and publish docker images #25

merged 6 commits into from
Nov 21, 2024

Conversation

mdesouky
Copy link
Contributor

@mdesouky mdesouky commented Nov 20, 2024 •
edited
Loading

Changes:

  • Configure repo with release-please
  • Build and push docker images

uptickmetachu
uptickmetachu approved these changes Nov 21, 2024
View reviewed changes
Copy link
Contributor

@uptickmetachu uptickmetachu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just check if we need the above point. I would prefer us not alloing the DEPLOY_KEY be used in a pull_request ,only on successful merges to masater.

.github/workflows/ci.yaml Show resolved Hide resolved
.github/workflows/ci.yaml Show resolved Hide resolved
@mdesouky
Copy link
Contributor Author

Just check if we need the above point. I would prefer us not alloing the DEPLOY_KEY be used in a pull_request ,only on successful merges to masater.

@uptickmetachu problem is we need to use the deploy key whenever we build the docker image, whether for testing on PRs or for releases and merges to master.

@mdesouky mdesouky merged commit 509238f into master Nov 21, 2024
2 checks passed
@mdesouky mdesouky deleted the dev-942/add-gha-workflow-to-build-docker-image branch November 21, 2024 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uptickmetachu uptickmetachu uptickmetachu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mdesouky @uptickmetachu