Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRAN-able / better build process #34

Open
5 tasks
Paxanator opened this issue May 27, 2019 · 0 comments
Open
5 tasks

CRAN-able / better build process #34

Paxanator opened this issue May 27, 2019 · 0 comments
Labels
enhancement New feature or request

Comments

@Paxanator
Copy link
Collaborator

In order to get on CRAN we need to make sure the following is done (some of this is sprucing up the build process too)

  • Make a configure.win and cleanup.win that does the same thing on windows
  • Allow local developers to opt out of pulling and installing librdkafka if they so choose, via an env var or something else. Update the CONTRIBUTING.md Development section with information
  • Figure out some best effort way of checking if the library is already installed in a default system path so a user doesn't need to compile all of the library. This doesn't need to be flawless but cover the obvious case of brew install or apt-get etc.
  • Ensure that no stray artifacts are being left behind from the build process.
  • Minimize path assumptions in Makevars and other places
@Paxanator Paxanator added the enhancement New feature or request label May 27, 2019
@Paxanator Paxanator added this to the cran initial release milestone May 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant