Rename SessionTx() to CreateTx() ?

[VojtechVitek]

I always forget how to create new DB transaction in upper/db.

err := DB.SessionTx(func(tx bond.Session) error {
     // tx
}

Whenever I search my codebase to remind myself, I end up git-grepping "CreateTransaction" or "CreateTx" but nothing comes up.

@xiam would you be open to renaming the SessionTx() method (or having an alias) to CreateTx() instead?

err := DB.CreateTx(func(tx bond.Session) error {
     // tx
}

@pkieltyka @c2h5oh @diogogmt @pxue thoughts?

[pkieltyka]

I like the name of it at first glance

…

On Apr 24, 2017, at 3:40 PM, Vojtech Vitek ***@***.***> wrote: I always forget how to create new DB transaction in upper/db. err := DB.SessionTx(func(tx bond.Session) error { // tx } Whenever I search my codebase to remind myself, I end up git-grepping "CreateTransaction" or "CreateTx" but nothing comes up. @xiam would you be open to renaming the SessionTx() method (or having an alias) to CreateTx() instead? err := DB.CreateTx(func(tx bond.Session) error { // tx } @pkieltyka @c2h5oh @diogogmt @pxue thoughts? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

[VojtechVitek]

@pkieltyka sorry - you like the original SessionTx() name? Or the proposed CreateTx() name?

[pkieltyka]

At a glance, I think CreateTx is more obvious what it does

…

On Apr 24, 2017, at 3:50 PM, Vojtech Vitek ***@***.***> wrote: @pkieltyka sorry - you like the original SessionTx() name? Or the proposed CreateTx() name? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

[xiam]

CreateTx sounds good, I opened an issue on bond to keep track of this one.