Skip to content
This repository has been archived by the owner on May 10, 2021. It is now read-only.

Document returned from connect.requestDisclosure() does not look like a full DID doc #193

Open
mi-xu opened this issue Aug 24, 2018 · 1 comment

Comments

@mi-xu
Copy link
Contributor

mi-xu commented Aug 24, 2018

Calling connect.requestDisclosure() results in a payload that looks like this:

{
  "data": undefined
  "id": "disclosureReq",
  "res": {
    "boxPub": undefined,
    "did": "did:uport: 2ofYLA3MayP4cMnr6fVHEzpvyckkUMwaqZ3",
  }
}
  • Should data and res.boxPub be undefined? If so, can we just omit them from the response?
  • It is my understanding that the res should be a DID document, but that doesn't seem to be the case. Is this just because I'm using a legacy mnid identity? If the response from this function is not supposed to be the DID doc, what function is supposed to return that, or is it meant to be abstracted away from the user by the uPort infrastructure?

Code sandbox example:
Edit uPort Connect Example

@rmw2
Copy link
Contributor

rmw2 commented Oct 23, 2018

Could be the legacy identity -- does this happen with an ethr-did?

But either way we should fix this

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants