Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please do not open PRs for this course in NumPy #179

Open
mattip opened this issue Oct 31, 2021 · 7 comments
Open

Please do not open PRs for this course in NumPy #179

mattip opened this issue Oct 31, 2021 · 7 comments

Comments

@mattip
Copy link

mattip commented Oct 31, 2021

It seems many people who forked this repo are also submitting dummy PRs to numpy/numpy#19828, numpy/numpy#20171, numpy/numpy#20203, numpy/numpy#20248 and especially numpy/numpy#20218.

If you are considering opening such a PR, please do not do so. It is a waste of NumPy's scarce resources to review and close these PRs.

@seberg
Copy link

seberg commented Oct 31, 2021

In my opinion, this is getting out of control and is not an acceptable way to interact with an open source project. We are used to and do not mind occasional stray PRs and issues: it is part of trying to be open to wide range of contributions and contributors.

But the same course leading to a dozen or more of them means that the course must be fixed. And it doesn't matter whether it was designed this way or is just confusing for students. It is the course material that is at fault here. Personally, by now I would like an apology from the teacher.

There are potentially hundreds of people getting notifications/emails for a new PR on NumPy, and just closing the PR will take a few minutes from a volunteer: Effectively, this has already cost several hours of volunteer time.

PRs that try to improve NumPy are always welcome, also as part of a course. But an open source project is not a venue for learning basic github usage. We are happy to help new contributors, but there is must be a clear intention of improving NumPy.

@seberg
Copy link

seberg commented Oct 31, 2021

@sajankedia are you involved in designing this course (sorry for the ping if not)?

@sajankedia
Copy link

sajankedia commented Nov 1, 2021 via email

@mattip
Copy link
Author

mattip commented Nov 1, 2021

@sajankedia, @upgrad-edu: Do you have any idea who is?

@sajankedia
Copy link

sajankedia commented Nov 1, 2021 via email

@tejaswiniallikanti
Copy link

tejaswiniallikanti commented Nov 1, 2021

Hi Seberg

I am a part of the team that handles the operations of the Git and GitHub course at upgrad. We have recently conducted a session aimed at showing our learners the process of contributing to an open-source library. Our learners started replicating the demonstrated scenario leading to the above redundant PRs. We deeply apologize for the trouble that was caused due to the pull requests. Please be assured that we are taking the necessary measures to reduce these attempts and also assure you that such trouble isn't caused in future.

Please do bear with us till we get this completely fixed.

-Tejaswini

@seberg
Copy link

seberg commented Nov 1, 2021

Thanks, courses showing how to contribute to open source is great! Just the way this turned out, created unnecessary spam for us.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants