Add support for jitter #204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toastwaffle
requested review from
bobh66,
ytsarev,
negz,
ulucinar,
sergenyalcin and
turkenf
as code owners
|
/test-examples="examples/workspace-inline-aws.yaml" |
ytsarev
approved these changes
Oct 20, 2023
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Add support for jitter in the poll interval, controlled by the
--poll-jitterflag. This defaults to 1 minute, which is 10% of the default poll interval.While making this change, I noticed that the
Setup()method ininternal/controller/terraform.gois never called - the provider binary callsworkspace.Setupdirectly, which means that there is no controller installed forProviderConfigs. I'm not sure if this is intentional.I have:
make reviewableto ensure this PR is ready for review.How has this code been tested
Ran
make test.