Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loading a vision lora fails with ValueError: Unrecognized model in lora_model. Should have a model_type key in its config.json #1322

Open
saum7800 opened this issue Nov 22, 2024 · 4 comments
Labels
fixed - pending confirmation Fixed, waiting for confirmation from poster URGENT BUG Urgent bug

Comments

@saum7800
Copy link

Ran the notebook for Qwen2 VL directly and ran into this issue when trying to load trained and saved lora model

Screenshot 2024-11-21 at 10 33 56 PM

not sure why the bug appears here but not in FastLanguageModel

@KarimMusleh
Copy link

KarimMusleh commented Nov 22, 2024

Can you link it please, I ran both of the Qwen notebooks and they seem to be working fine

@saum7800
Copy link
Author

saum7800 commented Nov 22, 2024

Did you change the False in the second last cell to True?

https://colab.research.google.com/drive/12pWo14IBaLgtlbxnsp-ocy59d8XujDZw?usp=sharing

interestingly, if I add qwen in the name of saved lora, it works, but that seems hacky

@danielhanchen danielhanchen added currently fixing Am fixing now! URGENT BUG Urgent bug labels Nov 22, 2024
@danielhanchen
Copy link
Contributor

Can repro - will fix it asap - sorry on the issue guys!

@danielhanchen danielhanchen added fixed - pending confirmation Fixed, waiting for confirmation from poster and removed currently fixing Am fixing now! labels Nov 26, 2024
@danielhanchen
Copy link
Contributor

@saum7800 @KarimMusleh Apologies just fixed it! Sorry on the delay! Please update Unsloth via: (or rerun Colab / Kaggle)

pip uninstall unsloth unsloth-zoo
pip install --upgrade --no-cache-dir --no-deps unsloth unsloth-zoo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fixed - pending confirmation Fixed, waiting for confirmation from poster URGENT BUG Urgent bug
Projects
None yet
Development

No branches or pull requests

3 participants