Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API: unkey-version header returning unknown #2615

Open
3 tasks done
Flo4604 opened this issue Oct 30, 2024 · 4 comments
Open
3 tasks done

API: unkey-version header returning unknown #2615

Flo4604 opened this issue Oct 30, 2024 · 4 comments
Labels
Bug Something isn't working Core Team

Comments

@Flo4604
Copy link
Contributor

Flo4604 commented Oct 30, 2024

Preliminary Checks

Reproduction / Replay Link (Optional)

No response

Issue Summary

The Unkey-Version header which normally shows the unkey version always returns unknown

Steps to Reproduce

  1. Send a request to https://api.unkey.dev
    Check the unkey-version header
    CleanShot 2024-10-30 at 10 58 11@2x

Expected behavior

It should return the version (github commit/hash) again

Other information

This got changed somewhere in between here
CleanShot 2024-10-30 at 10 49 40@2x

Screenshots

No response

Version info

Irrelevant
@Flo4604 Flo4604 added Bug Something isn't working Needs Approval Needs approval from Unkey labels Oct 30, 2024
Copy link

linear bot commented Oct 30, 2024

@Flo4604
Copy link
Contributor Author

Flo4604 commented Oct 30, 2024

Interestingly the canary deployments have the version set, see the latest failed run: https://github.com/unkeyed/unkey/actions/runs/11575910749/job/32228117890

@chronark
Copy link
Collaborator

/award 50
yeah, probably a small mistake
we used to inject this in ci manually, but iirc cloudflare now have a native way to use such metadata

Copy link

oss-gg bot commented Oct 30, 2024

Awarding Flo4604: 50 points 🕹️ Well done! Check out your new contribution on oss.gg/Flo4604

@perkinsjr perkinsjr added Core Team and removed Needs Approval Needs approval from Unkey labels Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Core Team
Projects
None yet
Development

No branches or pull requests

3 participants