-
Notifications
You must be signed in to change notification settings - Fork 511
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EXPIRED
and DISABLED
error codes do not include example JSON responses in Unkey Docs
#2300
Comments
/assign |
@2DELTA7 This ticket first needs to be approved by the repo owners. The |
/award 150 |
Awarding unrenamed: 150 points 🕹️ Well done! Check out your new contribution on oss.gg/unrenamed |
/assign |
Assigned to @HimanshuGaur14! Please open a draft PR linking this issue within 48h |
/assign |
This issue is already assigned to another person. Please find more issues here. |
/assign |
This issue is already assigned to another person. Please find more issues here. |
/assign |
This issue is already assigned to another person. Please find more issues here. |
/assign |
This issue is already assigned to another person. Please find more issues here. |
Let's add examples everywhere, rather than removing. I think it helps to understand what we return |
My system is facing a problem while im updating the issue , i won't be able to complete it please unassign me. |
you can unassign yourself too. Look at the top right corner or use /unassign command |
/unassign |
Issue unassigned. |
/assign |
Assigned to @joelwalice! Please open a draft PR linking this issue within 48h |
/assign |
Assigned to @rajtejani! Please open a draft PR linking this issue within 48h |
After carefully reviewing the code it seems like the issue is not related with Docs but actually these |
@rajtejani ah that might be yeah |
Running |
/assign |
This issue is already assigned to another person. Please find more issues here. |
/assign |
This issue is already assigned to another person. Please find more issues here. |
/assign |
Assigned to @Pk9697! Please open a draft PR linking this issue within 48h |
@Pk9697, Just a little reminder: Please open a draft PR linking this issue within 12 hours. If we can't detect a PR in 12h, you will be unassigned automatically. |
2 similar comments
@Pk9697, Just a little reminder: Please open a draft PR linking this issue within 12 hours. If we can't detect a PR in 12h, you will be unassigned automatically. |
@Pk9697, Just a little reminder: Please open a draft PR linking this issue within 12 hours. If we can't detect a PR in 12h, you will be unassigned automatically. |
Preliminary Checks
I have reviewed the documentation: https://unkey.com/docs
I have searched for existing issues: https://github.com/unkeyed/unkey/issues
This issue is not a question, general help request, or anything other than a bug report directly related to Unkey. Please ask questions in our Discord community: https://unkey.com/discord.
Reproduction / Replay Link (Optional)
No response
Issue Summary
Currently, the Unkey documentation provides example JSON responses for various error codes, enhancing clarity for developers. However, the
EXPIRED
andDISABLED
error codes are the only exceptions, as they do not include example JSON responses.Was it done intentionally? If no, see the proposed solutions in the Expected behavior.
https://www.unkey.com/docs/api-reference/errors/code/EXPIRED
https://www.unkey.com/docs/api-reference/errors/code/DISABLED
Steps to Reproduce
EXPIRED
orDISABLED
.Expected behavior
I propose one of the following solutions:
EXPIRED
andDISABLED
error codes for consistency.Both approaches would contribute to a more uniform documentation structure.
Other information
No response
Screenshots
Version info
The text was updated successfully, but these errors were encountered: