Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Insufficient padding in code block component on /templates page #2298

Open
3 tasks done
unrenamed opened this issue Oct 10, 2024 · 33 comments · May be fixed by ashokasec/unkey#1 or #2312
Open
3 tasks done

Insufficient padding in code block component on /templates page #2298

unrenamed opened this issue Oct 10, 2024 · 33 comments · May be fixed by ashokasec/unkey#1 or #2312
Assignees
Labels

Comments

@unrenamed
Copy link
Contributor

Preliminary Checks

Reproduction / Replay Link (Optional)

No response

Issue Summary

The code block component currently lacks adequate padding, making the displayed code appear cramped and suggesting that it continues beyond the right edge of the container. This design issue hampers readability and can confuse users, especially with longer code snippets.

Steps to Reproduce

  1. Visit https://www.unkey.com/templates/rust-rocket
  2. Scroll down to the steps with code blocks containing large code snippets

Expected behavior

To improve user experience, increasing the padding around the code block is necessary. Enhanced spacing will provide better visual separation, making it easier for users to engage with and understand the content.

Other information

No response

Screenshots

image image

Version info

- OS:
- Node:
- npm:
@unrenamed unrenamed added Bug Something isn't working Needs Approval Needs approval from Unkey labels Oct 10, 2024
Copy link

linear bot commented Oct 10, 2024

@ashokasec
Copy link

/assign

1 similar comment
@Anurag-singh-thakur
Copy link

/assign

@perkinsjr perkinsjr added 🕹️ oss.gg 🕹️ 150 points and removed Needs Approval Needs approval from Unkey labels Oct 10, 2024
@perkinsjr
Copy link
Collaborator

/award 150

Copy link

oss-gg bot commented Oct 10, 2024

Awarding unrenamed: 150 points 🕹️ Well done! Check out your new contribution on oss.gg/unrenamed

@perkinsjr
Copy link
Collaborator

I believe this issue is specific to the layout itself and not the code block as the codeblock is reused in multiple places. for anyone who picks this up

@prakashsp23
Copy link

/assign

Copy link

oss-gg bot commented Oct 10, 2024

Assigned to @prakashsp23! Please open a draft PR linking this issue within 48h ⚠️ If we can't detect a PR from you linking this issue in 48h, you'll be unassigned automatically 🕹️ Excited to have you ship this 🚀

@sdshaheer
Copy link

/assign

Copy link

oss-gg bot commented Oct 10, 2024

This issue is already assigned to another person. Please find more issues here.

@Rayyos
Copy link

Rayyos commented Oct 10, 2024

/assign

Copy link

oss-gg bot commented Oct 10, 2024

This issue is already assigned to another person. Please find more issues here.

@VenkateshSircilla123
Copy link

/assign

Copy link

oss-gg bot commented Oct 10, 2024

This issue is already assigned to another person. Please find more issues here.

@ashokasec
Copy link

ashokasec commented Oct 10, 2024

@unrenamed fixed the padding issue, can you just check it once? PR-2312

@prakashsp23 prakashsp23 removed their assignment Oct 11, 2024
@devXpraAddy
Copy link

/assign

Copy link

oss-gg bot commented Oct 11, 2024

Assigned to @devXpraAddy! Please open a draft PR linking this issue within 48h ⚠️ If we can't detect a PR from you linking this issue in 48h, you'll be unassigned automatically 🕹️ Excited to have you ship this 🚀

@mrjayantbokade
Copy link

/assign

Copy link

oss-gg bot commented Oct 11, 2024

This issue is already assigned to another person. Please find more issues here.

@zubairahmed22
Copy link

/assign

Copy link

oss-gg bot commented Oct 11, 2024

This issue is already assigned to another person. Please find more issues here.

@shindebhavika
Copy link

/assign

Copy link

oss-gg bot commented Oct 11, 2024

This issue is already assigned to another person. Please find more issues here.

@abhicodes01
Copy link

/assign

Copy link

oss-gg bot commented Oct 11, 2024

This issue is already assigned to another person. Please find more issues here.

@xRiddin
Copy link

xRiddin commented Oct 11, 2024

/assign

Copy link

oss-gg bot commented Oct 11, 2024

This issue is already assigned to another person. Please find more issues here.

@Sa1-Codes
Copy link

/assign

Copy link

oss-gg bot commented Oct 11, 2024

This issue is already assigned to another person. Please find more issues here.

@OptimisticTech-Amber
Copy link

/assign

Copy link

oss-gg bot commented Oct 12, 2024

This issue is already assigned to another person. Please find more issues here.

@Manik445
Copy link

/assign

Copy link

oss-gg bot commented Oct 12, 2024

This issue is already assigned to another person. Please find more issues here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment