Editing & Undoing for warns and notes

[elkowar]

The warn and note commands should have a !note undo <user> / !warn undo <user> command to remove the latest warn / note.

[mlvzk]

Instead of !note undo I think it would be better to do !note undo <note_id>. For this we would need !note to show notes together with their IDs, but the IDs are pretty long so we should just show the last 3 or 4 characters and use that in !note undo <note_id>

[elkowar]

we could also just make them indices, show the numbers and then do !note remove <note-nr> (that number just being an index). would not be quite as easy to implement (idk is there a way to do "delete the nth element in chronological order" in sql?), but would be a much better UX and lessen the theoretical possibility of a wrong deletion

[mlvzk]

Yes, that would be better.
You could sort oldest to newest, skip <note-nr>, limit 1 and delete that

[elkowar]

sounds good!

[davidv171]

Should people see undone notes for a user? Maybe use strikethrough when creating a replied messages based on an "isActive" field? Instead of just completely wiping from the database.

[elkowar]

I don’t think that’s necessarily a good idea, as I would say the main intent behind an undo is being able to undo things like spelling errors, bad note descriptions, accidentally tagging the wrong user, etc. A note or warn that has been given for a good reason should never be removed at all. If the person apologises or whatever, we can add another note saying that, but I’d not want to remove it there,

[elkowar]

Of course this is just my understanding of the purpose here, if others Have different ideas I’m open of course