Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate: Does subtraction of a checkpointed value mean rounding might not favor protocol in certain scenarios #68

Open
apbendi opened this issue Mar 15, 2024 · 0 comments
Assignees

Comments

@apbendi
Copy link
Collaborator

apbendi commented Mar 15, 2024

At this line, we see that one checkpointed value, which may have been truncated due to a division, is subtracted from another. This might mean rounding could favor the user, rather than the protocol. But the scale factor might protect us from this. Further investigation is needed to see if a specific scenario could be created wherein rounding might favor the user instead of the contract.

@apbendi apbendi self-assigned this Mar 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant