Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Spatial Dependencies in AccessMod #438

Open
fxi opened this issue Jun 14, 2024 · 0 comments
Open

Refactor Spatial Dependencies in AccessMod #438

fxi opened this issue Jun 14, 2024 · 0 comments

Comments

@fxi
Copy link
Collaborator

fxi commented Jun 14, 2024

We've identified issues affecting AccessMod related to outdated spatial packages:

  1. The raster package has been replaced by terra.
  2. The rgeos package should be replaced by terra or sf.
  3. rgrass now requires the use of terra and sf.
  4. The sp package is considered outdated and should be replaced by sf.

Currently, our code forces rgrass to use sp, which is not recommended. Continuing to automate builds with obsolete packages is not sustainable.

Additionally, AccessMod uses proj4, which is also obsolete. We need to transition to WKT projection definitions. I've found alternatives for determining projection units and types during project creation and uploads, but proj4 is still used elsewhere in the codebase.

There are related issues (#437 and #433) that point towards the need for a comprehensive refactor of AccessMod's spatial dependencies.

GRASS GIS Updates:
GRASS has evolved significantly, though I haven't noticed any breaking changes. There is a minor bug fix needed for r.walk, which I can integrate into r.walk.accessmod during the build process.

Action Required:
We need to rethink spatial operations in AccessMod, excluding GRASS. GRASS-related operations should remain mostly unaffected.

More info
https://r-spatial.org/r/2022/04/12/evolution.html
https://geocompx.org/post/2023/rgdal-retirement/index.html
https://github.com/r-spatial/evolution?tab=readme-ov-file
https://github.com/r-spatial/evolution/blob/main/pkgapi_230305_refs.csv

@fxi fxi self-assigned this Jun 14, 2024
@fxi fxi moved this to To do 🐞 in AccessMod - dev planning Jun 14, 2024
@fxi fxi moved this from Done ✅ to To be tested 🧐 in AccessMod - dev planning Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: To be tested 🧐
Development

No branches or pull requests

1 participant