[FEATURE REQUEST] updateOrderDeliveryPickUp should support multipel different pickup providers

[macrozone]

Introduction

updateOrderDeliveryPickUp does assume that the order has already a pickup delivery configured, otherwise it will fail silently.

Is your feature request related to a problem? Please describe.

if you have multipe delivery pickup provider, the problem is more severe. You can't change the delivery provider and set a new pickup location at the same time. You would need to call first setOrderDeliveryProvider and then updateOrderDeliveryPickUp .

this is very tedious

Describe the solution you'd like

updateOrderDeliveryPickUp should take a providerId

Describe the design of the solution in detail

simple: updateOrderDeliveryPickUp also allows to change the provider

Describe alternatives you've considered

none

[pozylon]

Referred mutation:

const UpdateOrderDeliveryPickUpMutation = gql`
  mutation UpdateOrderDeliveryPickUp(
    $orderId: ID!
    $deliveryProviderId: ID!
    $orderDeliveryId: ID!
    $orderPickUpLocationId: ID!
  ) {
    setOrderDeliveryProvider(
      orderId: $orderId
      deliveryProviderId: $deliveryProviderId
    ) {
      _id
    }
    updateOrderDeliveryPickUp(
      orderDeliveryId: $orderDeliveryId
      orderPickUpLocationId: $orderPickUpLocationId
    ) {
      _id
      activePickUpLocation {
        _id
      }
    }
  }
`;

[pozylon]

Currently Unchained creates or reuses an existing OrderDelivery when "setOrderDeliveryProvider" is used. So you can't even do the upper mutation because you don't know the correct orderDeliveryId until you have set the delivery provider on the cart.

const delivery = OrderDeliveries.findOne({ orderId, deliveryProviderId });
  const deliveryId = delivery
    ? delivery._id
    : OrderDeliveries.createOrderDelivery({ orderId, deliveryProviderId })._id;

I suppose we do a breaking schema change:

From:

      setOrderDeliveryProvider(orderId: ID!, deliveryProviderId: ID!): Order!
      setOrderPaymentProvider(orderId: ID!, paymentProviderId: ID!): Order!
      updateOrderDeliveryShipping(
        orderDeliveryId: ID!
        address: AddressInput
        meta: JSON
      ): OrderDeliveryShipping!
      updateOrderDeliveryPickUp(
        orderDeliveryId: ID!
        orderPickUpLocationId: ID!
        meta: JSON
      ): OrderDeliveryPickUp!

To:

      setOrderDeliveryProvider(orderId: ID, deliveryProviderId: ID!): Order!
      setOrderPaymentProvider(orderId: ID, paymentProviderId: ID!): Order!
      updateOrderDeliveryShipping(
        orderId: ID
        deliveryProviderId: ID!
        orderDeliveryId: ID! @deprecated(reason: "Use orderId & deliveryProviderId to select the order delivery")
        address: AddressInput
        meta: JSON
      ): OrderDeliveryShipping!
      updateOrderDeliveryPickUp(
        orderId: ID
        deliveryProviderId: ID!
        orderDeliveryId: ID! @deprecated(reason: "Use orderId & deliveryProviderId to select the order delivery")
        orderPickUpLocationId: ID!
        meta: JSON
      ): OrderDeliveryPickUp!

• we do as @macrozone said and set the order delivery when using one of the updateOrderDeliveryPickUp or updateOrderDeliveryShipping mutations.

The mutation from @macrozone could then be done like this (drop explicit orderId because current cart is assumed):

const UpdateOrderDeliveryPickUpMutation = gql`
  mutation UpdateOrderDeliveryPickUp(
    $deliveryProviderId: ID!
    $orderPickUpLocationId: ID!
  ) {
    updateOrderDeliveryPickUp(
      deliveryProviderId: $deliveryProviderId
      orderPickUpLocationId: $orderPickUpLocationId
    ) {
      _id
      activePickUpLocation {
        _id
      }
      order {
        _id
       delivery { _id }  
      }
    }
  }
`;

[pozylon]

We got another issue with a new case also conflicting with the current concept.

It basically boils down to the problem that in order to get a list of pickup locations you have to set the delivery provider on the cart first.

So additionally to these changes, we should find a way to let the user query for pickup locations baed on the PROVIDER.

-> DeliveryProvider.pickUpLocations instead of OrderDelivery.pickUpLocations