Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code refactor for Issue #40 #43

Merged
merged 1 commit into from
Sep 15, 2024
Merged

Code refactor for Issue #40 #43

merged 1 commit into from
Sep 15, 2024

Conversation

oneils
Copy link
Contributor

@oneils oneils commented Sep 15, 2024

  • added constructor for Server so that it responsible for Server creation with templates cache.

Additionally, validation parameters like PinSize, MaxAttempts and MaxExpire can be moved to a separate struct like

type ValidationConfig struct {
    PinSize        int
    MaxPinAttempts int
    MaxExpire      time.Duration
}

@umputun , please let m know if you have any objections or suggestions.

@oneils oneils mentioned this pull request Sep 15, 2024
Merged
umputun
umputun reviewed Sep 15, 2024
View reviewed changes
Copy link
Owner

@umputun umputun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a small suggestion

app/server/server_test.go Outdated Show resolved Hide resolved
@oneils oneils force-pushed the issue-refactor-for-issue-40 branch from f69f506 to a442250 Compare September 15, 2024 20:16
@coveralls
Copy link

Pull Request Test Coverage Report for Build 10873996030

Details

  • 19 of 35 (54.29%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.2%) to 67.305%
Changes Missing Coverage Covered Lines Changed/Added Lines %
app/server/server.go 18 20 90.0%
app/server/web.go 1 15 6.67%
Totals Coverage Status
Change from base Build 10230138733: 0.2%
Covered Lines: 562
Relevant Lines: 835
💛 - Coveralls

@umputun umputun merged commit 26c897f into umputun:master Sep 15, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@umputun umputun umputun approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@oneils @coveralls @umputun