Issue #40:http protocol is hardcoded in the URL #41
+6
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 10874056384Details
💛 - Coveralls |
umputun
requested changes
Sep 7, 2024
There was a problem hiding this comment.
Thanks for the PR. It looks fine, but not an easy one to review as, in addition to the expected (small) change, it also changed other things, like public/private visibility of some structs and fields.
It would be nice if you could split it into two commits: one with the actual protocol change and another with everything else you have improved.
|
Sure, no problem. I'll do it |
- moved hardcoded protocol to an argument
oneils
force-pushed
the
issue-40-fix-http
branch
from
2269bc9 to
2db4c8c
Compare
umputun
approved these changes
Sep 16, 2024
umputun
approved these changes
Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Must be merged after #43