Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pnpm from v7 to v8 #1845

Merged
merged 1 commit into from
Nov 10, 2024
Merged

Update pnpm from v7 to v8 #1845

merged 1 commit into from
Nov 10, 2024

Conversation

paskal
Copy link
Collaborator

@paskal paskal commented Nov 10, 2024

That suppose to help with Dependabot security updates not updating lockfile.

Size checks failing because it checks out old code version which doesn't allow pnpm v8.

Copy link

codecov bot commented Nov 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.16%. Comparing base (63048cc) to head (b02935b).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1845   +/-   ##
=======================================
  Coverage   65.16%   65.16%           
=======================================
  Files         140      140           
  Lines        3508     3508           
  Branches      782      782           
=======================================
  Hits         2286     2286           
  Misses       1151     1151           
  Partials       71       71           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@paskal paskal force-pushed the paskal/update_pnpm branch from bdaed78 to 183a88f Compare November 10, 2024 19:18
@paskal paskal marked this pull request as ready for review November 10, 2024 19:20
That suppose to help with Dependabot security updates not updating lockfile.
@paskal paskal force-pushed the paskal/update_pnpm branch from 183a88f to b02935b Compare November 10, 2024 19:23
@paskal paskal marked this pull request as draft November 10, 2024 19:25
@paskal paskal marked this pull request as ready for review November 10, 2024 19:29
@umputun umputun merged commit 3001b37 into master Nov 10, 2024
13 of 14 checks passed
@umputun umputun deleted the paskal/update_pnpm branch November 10, 2024 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants