-
-
Notifications
You must be signed in to change notification settings - Fork 387
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Discord OAuth support #1824
Conversation
You can update to latest master of auth package instead and not wait for the version release. |
I've done the same, thanks. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1824 +/- ##
========================================
Coverage 64.24% 64.24%
========================================
Files 140 140
Lines 3230 3230
Branches 773 815 +42
========================================
Hits 2075 2075
+ Misses 1151 1038 -113
- Partials 4 117 +113 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
@mgkbadola thanks a lot! Could you please run Remark42 with Discord auth enabled and post a screenshot of how the auth icon looks like and verify that you can log in using that method? |
Hey @paskal |
Let me know how can I help to resolve this |
No need to do anything from your side @mgkbadola, it's a fault of our CI setup which doesn't highlight the problem where it should. The failing test is already fixed. |
Completes Discord OAuth integration on frontend. Can only be merged when a new version of go-pkgz/auth is released with Discord OAuth backend support (reference).