Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Discord OAuth support #1824

Merged
merged 7 commits into from
Nov 18, 2024
Merged

feat: Discord OAuth support #1824

merged 7 commits into from
Nov 18, 2024

Conversation

mgkbadola
Copy link
Contributor

Completes Discord OAuth integration on frontend. Can only be merged when a new version of go-pkgz/auth is released with Discord OAuth backend support (reference).

@paskal
Copy link
Collaborator

paskal commented Nov 8, 2024

You can update to latest master of auth package instead and not wait for the version release.

@mgkbadola
Copy link
Contributor Author

I've done the same, thanks.

@mgkbadola mgkbadola marked this pull request as ready for review November 10, 2024 07:15
@mgkbadola mgkbadola requested a review from umputun as a code owner November 10, 2024 07:15
Copy link

codecov bot commented Nov 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.24%. Comparing base (3646c4a) to head (d0dc113).
Report is 11 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff            @@
##           master    #1824    +/-   ##
========================================
  Coverage   64.24%   64.24%            
========================================
  Files         140      140            
  Lines        3230     3230            
  Branches      773      815    +42     
========================================
  Hits         2075     2075            
+ Misses       1151     1038   -113     
- Partials        4      117   +113     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@paskal
Copy link
Collaborator

paskal commented Nov 10, 2024

@mgkbadola thanks a lot! Could you please run Remark42 with Discord auth enabled and post a screenshot of how the auth icon looks like and verify that you can log in using that method?

@badolamgk
Copy link
Contributor

Hey @paskal
Here are the screenshots from my trial run.

Able to login and comment via Discord as intended.
Screenshot 2024-11-12 at 9 18 29 PM
Screenshot 2024-11-12 at 9 19 40 PM

@umputun umputun merged commit 16ff269 into umputun:master Nov 18, 2024
13 checks passed
@paskal
Copy link
Collaborator

paskal commented Dec 2, 2024

@umputun interesting case: this PR broke backend tests in master (fixed in #1862), but the latest commit is merge commit which doesn't touch backend so the tests were not run. No idea what to do about it aside from asking the requestor to squash commits locally.

@mgkbadola
Copy link
Contributor Author

Let me know how can I help to resolve this

@paskal
Copy link
Collaborator

paskal commented Dec 2, 2024

No need to do anything from your side @mgkbadola, it's a fault of our CI setup which doesn't highlight the problem where it should. The failing test is already fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants