Comment content styles #1704
Merged
Comment content styles #1704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akellbl4
commented
Nov 25, 2023
| @@ -1,129 +0,0 @@ | |||
| .raw-content { | |||
| & .root_theme_dark { | |||
There was a problem hiding this comment.
Wrong nesting, should've been .root_theme_dark &
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1704 +/- ##
==========================================
- Coverage 65.20% 61.47% -3.74%
==========================================
Files 141 132 -9
Lines 3512 2998 -514
Branches 824 757 -67
==========================================
- Hits 2290 1843 -447
Misses 1038 1038
+ Partials 184 117 -67 ☔ View full report in Codecov by Sentry. |
size-limit report 📦
|
akellbl4
commented
Nov 25, 2023
| className={b('comment-form__preview', { | ||
| mix: b('raw-content', {}, { theme }), | ||
| })} | ||
| className="comment-form__preview raw-content" |
There was a problem hiding this comment.
theme set to root tag as dark so we don't need additional theming tag
…ve styles to correct place
paskal
force-pushed
the
ak/raw-content-styles
branch
from
64055b6 to
f24d044
Compare
Pull Request Test Coverage Report for Build 7512286614
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
codeblock causes content to be hidden #1629pre > code(the way chroma generates html)prehad size 85% andcodehad 85% from it.Before
After