Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract error message from API response for preview. #1674

Merged
merged 1 commit into from
Oct 8, 2023

Conversation

sharief007
Copy link
Contributor

Change Log

  • For preview errors, only isErrorShown is set to true and errorMessage is not provided. Hence the comment form shows Something went wrong. Please try again a bit later. (generic message) by default for all preview errors.
  • Refactored the exception handling to derive error message from the response code (similar to send method). Now both Send and Preview shows the same error message.

Resolves: #1673

@sharief007 sharief007 requested a review from umputun as a code owner September 17, 2023 19:28
@codecov
Copy link

codecov bot commented Sep 17, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (c9b6f92) 61.55% compared to head (879db73) 61.55%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff            @@
##           master    #1674    +/-   ##
========================================
  Coverage   61.55%   61.55%            
========================================
  Files         133      133            
  Lines        3004     3004            
  Branches      752      759     +7     
========================================
  Hits         1849     1849            
- Misses       1038     1151   +113     
+ Partials      117        4   -113     
Files Changed Coverage Δ
...ark42/app/components/comment-form/comment-form.tsx 53.30% <0.00%> (ø)

... and 23 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@umputun umputun requested review from paskal and akellbl4 September 27, 2023 06:44
Copy link
Collaborator

@akellbl4 akellbl4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sharief007 thank you!

@umputun umputun merged commit eba4473 into umputun:master Oct 8, 2023
8 of 9 checks passed
@paskal
Copy link
Collaborator

paskal commented Oct 9, 2023

Thanks a lot! I've checked now and it works as expected.

@paskal paskal added this to the v1.13.0 milestone Mar 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lack of frontend information about relative URL
4 participants