Skip to content

Commit

Permalink
update node to v20 lts
Browse files Browse the repository at this point in the history
  • Loading branch information
akellbl4 committed Oct 28, 2023
1 parent 69b18d3 commit 6c786ef
Show file tree
Hide file tree
Showing 9 changed files with 2,187 additions and 2,062 deletions.
6 changes: 3 additions & 3 deletions .github/workflows/ci-frontend-api.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
node: [16.15.1]
node: [20.9.0]

steps:
- name: Checkout
Expand Down Expand Up @@ -64,7 +64,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
node: [16.15.1]
node: [20.9.0]

steps:
- name: Checkout
Expand Down Expand Up @@ -108,7 +108,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
node: [16.15.1]
node: [20.9.0]

steps:
- name: Checkout
Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/ci-frontend.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
node: [16.15.1]
node: [20.9.0]

steps:
- name: Checkout
Expand Down Expand Up @@ -64,7 +64,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
node: [16.15.1]
node: [20.9.0]

steps:
- name: Checkout
Expand Down Expand Up @@ -108,7 +108,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
node: [16.15.1]
node: [20.9.0]

steps:
- name: Checkout
Expand Down Expand Up @@ -176,7 +176,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
node: [16.15.1]
node: [20.9.0]

steps:
- name: Checkout
Expand Down
2 changes: 1 addition & 1 deletion Dockerfile
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM --platform=$BUILDPLATFORM node:16.15.1-alpine AS frontend-deps
FROM --platform=$BUILDPLATFORM node:20.9.0-alpine AS frontend-deps

ARG SKIP_FRONTEND_TEST
ARG SKIP_FRONTEND_BUILD
Expand Down
2 changes: 1 addition & 1 deletion Dockerfile.artifacts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM node:16.15.1-alpine AS frontend-deps
FROM node:20.9.0-alpine AS frontend-deps

ENV CI=true

Expand Down
1 change: 1 addition & 0 deletions frontend/.npmrc
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
use-node-version=20.9.0
1 change: 0 additions & 1 deletion frontend/.nvmrc

This file was deleted.

4 changes: 0 additions & 4 deletions frontend/apps/remark42/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -21,10 +21,6 @@
"translation:generate": "node ./tasks/generateDictionary.js",
"translation:check": "node ./tasks/checkTranslation.js"
},
"engines": {
"node": ">=16.15 <=17.*",
"pnpm": "7.*"
},
"dependencies": {
"@github/markdown-toolbar-element": "^2.1.1",
"@github/text-expander-element": "^2.2.2",
Expand Down
4 changes: 4 additions & 0 deletions frontend/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,10 @@
"comment engine",
"commenting"
],
"engines": {
"node": ">=16.15 <=20.*",
"pnpm": ">=7.* <=8.*"
},
"scripts": {
"prepare": "if [ -z \"$CI\" ]; then cd .. && husky install frontend/.husky; else echo \"Skip Husky Hooks\"; fi",
"lint-staged": "lint-staged",
Expand Down
Loading

0 comments on commit 6c786ef

Please sign in to comment.