Revert "feat: support unplugin context (#1728)" #1737
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 3dd6d9d.
WalkthroughThis pull request reverts the changes made in a previous commit (3dd6d9d) related to supporting unplugin context. The revert addresses an issue where an undefined filePath was encountered, as referenced in the provided link. Changes
|
![petercat-assistant[bot]](https://avatars.githubusercontent.com/in/875736?s=60&v=4){kind=small}
| pub transform: | ||
| Option<ThreadsafeFunction<(PluginContext, String, String), Option<TransformResult>>>, | ||
| pub transform_include: Option<ThreadsafeFunction<(PluginContext, String), Option<bool>>>, | ||
| pub build_start: Option<ThreadsafeFunction<(), ()>>, |
There was a problem hiding this comment.
The removal of PluginContext from TsFnHooks may lead to issues if any functionality relied on the context being passed. Ensure that this change does not break any existing functionality that depends on PluginContext.
|
Caution Review failedThe pull request is closed. 概述遍历这个拉取请求主要简化了 Mako 构建系统中的插件上下文处理。通过移除 变更
序列图sequenceDiagram
participant Plugin
participant BuildSystem
participant Hook
Plugin->>BuildSystem: 注册钩子
BuildSystem->>Hook: 调用钩子函数
Hook-->>BuildSystem: 返回结果
可能相关的 PR
诗歌
📜 Recent review detailsConfiguration used: CodeRabbit UI ⛔ Files ignored due to path filters (2)
📒 Files selected for processing (21)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1737 +/- ##
=======================================
Coverage 54.82% 54.82%
=======================================
Files 180 180
Lines 18053 18053
=======================================
Hits 9897 9897
Misses 8156 8156 ☔ View full report in Codecov by Sentry. |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 3dd6d9d.
Ref: https://github.com/ant-design/ant-design/actions/runs/12576684269/job/35054329597?pr=52120
Received an undefined filePath here:
https://github.com/umijs/dumi/blob/21e1585460fec2ef183695247aac30177992f09e/src/features/compile/makoHooks.ts#L50
Summary by CodeRabbit
以下是发行说明：
新功能
重大变更
PluginContext结构文档更新
依赖变更
@iconify-json/mdi、unplugin-icons和unplugin-replace依赖测试和示例