Version filter doesn't appear to be working when searching

[PeteDuncanson]

As mentioned in #577 if you search for https://our.umbraco.com/search?q=migrations and have the default "V8" target version selected next to the search box the results seem to be from all versions and not just for V8 as I would expect.

[nul800sebastiaan]

Aha.. not sure why that wouldn't work on the main search, it looks like it only works for the docs, but it should of course work everywhere.

[umbrabot]

Hi @PeteDuncanson,

We're writing to let you know that we've added the Up For Grabs label to your issue. We feel that this issue is ideal to flag for a community member to work on it. Once flagged here, folk looking for issues to work on will know to look at yours. Of course, please feel free work on this yourself ;-). If there are any changes to this status, we'll be sure to let you know.

For more information about issues and states, have a look at this blog post

Thanks muchly, from your friendly PR team bot :-)

[AaronSadlerUK]

Submitted a PR: #641

[leekelleher]

I'm not sure whether the bug I've encountered is the same as this one... or whether the PR #641 fix resolves it too.
So posting on here, rather than creating a new ticket.

In a nutshell, when I filter the package listing by "Version 8", my Contentment package isn't listed. But if I select "Any" version it is listed. 🤷

I originally thought it was an UmbPack issue, so I've posted in more humous detail on their repo: umbraco/UmbPack#62

The suggestion is that the "Version 8" filter is only showing packages that are associated with v8.0+ only. Where as my Contentment package is for v8.6+, so doesn't show. But interestingly does show if you manually tweak the querystring to be v8.6.

[KevinJump]

Had a look I think its how the packages are indexed and searched.

the versions are indexed here :

OurUmbraco/OurUmbraco/Our/Examine/ProjectNodeIndexDataService.cs

Line 235 in 326292c

var allVersions = new HashSet<string>();

but they are then only referenced in the filters, which goes back to the major version .

I think - the fix is to add the major versions (to the num_version version field) when indexing the package - then the filter can use that.

[umbrabot]

Hiya @PeteDuncanson,

Just wanted to let you know that we noticed that this issue got a bit stale and might not be relevant any more.

We will close this issue for now but we're happy to open it up again if you think it's still relevant (for example: it's a feature request that's not yet implemented, or it's a bug that's not yet been fixed).

To open it this issue up again, you can write @umbrabot still relevant in a new comment as the first line. It would be super helpful for us if on the next line you could let us know why you think it's still relevant.

For example:

@umbrabot still relevant
This bug can still be reproduced in version x.y.z

This will reopen the issue in the next few hours.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂