Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Upcoming meetups" only show one event per group #532

Closed
abjerner opened this issue Jan 12, 2020 · 4 comments · May be fixed by #566
Closed

"Upcoming meetups" only show one event per group #532

abjerner opened this issue Jan 12, 2020 · 4 comments · May be fixed by #566
Labels

Comments

@abjerner
Copy link
Contributor

The Upcoming meetups section on the front page currently only shows one event per group. IIRC it was made so by design, but it feels a bit misleading that not all events are shown.

As an example, the Danish group has an event the 29th, but as it also has one before that on the 23rd, meaning the one on the 29th isn't shown - yet there are two events shown that are dated in February.

Even if there is a super active meetup group, I can't see a problem in showing their upcoming events, so my proposal is to either:

  1. show X number of upcoming events regardless of their parent groups (fixed amount)
  2. show all upcoming events in the X next days (dynamic amount)

image

image

@nul800sebastiaan
Copy link
Member

Hmmm, somehow this just showed up in my "unanswered" list for the first time!

Yes, you're right, I think showing all the upcoming events in the next 30 days would be the nicest. 👍

@umbrabot
Copy link

umbrabot commented Feb 5, 2020

Hi @abjerner,

We're writing to let you know that we've added the Up For Grabs label to your issue. We feel that this issue is ideal to flag for a community member to work on it. Once flagged here, folk looking for issues to work on will know to look at yours. Of course, please feel free work on this yourself ;-). If there are any changes to this status, we'll be sure to let you know.

For more information about issues and states, have a look at this blog post

Thanks muchly, from your friendly PR team bot :-)

jameswilki added a commit to jameswilki/OurUmbraco that referenced this issue Apr 11, 2020
Also added try-catch to handle Invalid responses
jameswilki added a commit to jameswilki/OurUmbraco that referenced this issue Apr 11, 2020
@jameswilki
Copy link

I've taken a look at this and submitted PR #566 for review.

@umbrabot
Copy link

Hiya @abjerner,

Just wanted to let you know that we noticed that this issue got a bit stale and might not be relevant any more.

We will close this issue for now but we're happy to open it up again if you think it's still relevant (for example: it's a feature request that's not yet implemented, or it's a bug that's not yet been fixed).

To open it this issue up again, you can write @umbrabot still relevant in a new comment as the first line. It would be super helpful for us if on the next line you could let us know why you think it's still relevant.

For example:

@umbrabot still relevant
This bug can still be reproduced in version x.y.z

This will reopen the issue in the next few hours.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

@umbrabot umbrabot added the status/stale Marked as stale due to inactivity label Apr 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants