-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Forward decls in multi_handle.hxx #533
Comments
I'm happy to be a little more agressive with the visual studio versions to help modernize the build. Now that we have the CIs running, we can make a few CIs with different compiler versions. |
Do I understand you correctly that you are in favor of enabling these forward decls unconditionally - and accepting compilation problems on old Visual Studio versions? If yes, I can prepare a PR. |
yes |
mkrausex
pushed a commit
to mkrausex/vigra
that referenced
this issue
Oct 19, 2023
hmaarrfk
pushed a commit
that referenced
this issue
Nov 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
There are two forward decls at the beginning of
multi_handle.hxx
which, according to a comment there, “Visual Studio doesn't like”, and are currently disabled via#ifndef _MSC_VER
. However, Visual Studio 2019 in C++20 mode actually seems to expect these forward decls – the code compiles only if I enable them (i.e., when I remove the#ifndef _MSC_VER
).What would be a good solution? I guess that for some older version of Visual Studio, these forward decls had really been a problem originally. Maybe we should only keep them disabled for all Visual Studio versions before 2019, and enable them for 2019 and later? Or should it be conditional on the C++ standard version instead?
The text was updated successfully, but these errors were encountered: