You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All sub component pull requests have been reviewed by their code managers.
Run the full Intel+GNU RT suite (compared to current baselines) on either Hera/Derecho/Hercules
Commit 'test_changes.list' from previous step
Description:
This PR contains many non-Boussinesq related code enhancement, alone with many new features (see detail at mom-ocean/MOM6#1616 and NOAA-EMC/MOM6#127).
Commit Message:
* MOM6 -
update MOM6 to its main repo. 20240228 updating (which is the original GFDL 20231113 candidate PR)
Priority:
High: this is a longlasting PR which finally reached merging staging (after 3.5 months). Need to merge it to dev/emc and start to work on "remove compiling warning" right after this. Due to the complication of this PR, it's better to treat it as an independent PR.
Regression Test Changes (Please commit test_changes.list):
PR Updates/Changes Baselines.
(1) cpld_control_c48: two new variables are being added in this setting (p_surf_EOS=True), this is why you will see all files are OK in cmp except ocean restart files on all platforms (except wcoss2). For wcoss2 answers are being changed.
(2) hafs_regional_storm_following_1nest_atm_ocn_wav_mom6: a bug fixing is included which changed answer in this PR
which originally is 20231113 PR candidate
* pointing to MOM6 testing branch
* midify MOm6 cmake list to reflect file changes
(1) add new file src/parameterizations/lateral/MOM_self_attr_load.F90
(2) MOM_unit_test_driver.F90 rename to test_MOM_file_parser.F90
(3) add new files: time_MOM_EOS.F90, test_MOM_EOS.F90, test_MOM_mixedlayer_restrat.F90
test_MOM_string_functions.F90 and test_MOM_string_functions.F90
* change DEFAULT_2018_ANSWERS=T to DEFAULT_ANSWER_DATE=20181231 for 025, 05 and 100 setting
due to the super size and complication, this PR branch has been tested on all platforms (thanks for the help from @DeniseWorthen and @jkbk2004). Regression logs:
@zach1221@jkbk2004 FYI Gaea has run into errors with the hafs_regional_storm_following_1nest_atm_ocn_wav_mom6 test during runtime. It seems to be caused by obsolete runtime flags: /gpfs/f5/epic/scratch/Fernando.Andrade-maldonado/FV3_RT/rt_73775/hafs_regional_storm_following_1nest_atm_ocn_wav_mom6_intel/err
360: FATAL from PE 0: MOM_obsolete_params: DEFAULT_2018_ANSWERS is an obsolete run-time flag, and should not be used. Instead use DEFAULT_ANSWER_DATE.
Baseline UpdatesCurrent baselines will be updated.Ready for Commit QueueThe PR is ready for the Commit Queue. All checkboxes in PR template have been checked.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
zach1221
added
Baseline Updates
Commit Queue Requirements:
Description:
This PR contains many non-Boussinesq related code enhancement, alone with many new features (see detail at mom-ocean/MOM6#1616 and NOAA-EMC/MOM6#127).
Commit Message:
Priority:
Git Tracking
UFSWM:
close #2165
Sub component Pull Requests:
UFSWM Blocking Dependencies:
Changes
Regression Test Changes (Please commit test_changes.list):
(1) cpld_control_c48: two new variables are being added in this setting (p_surf_EOS=True), this is why you will see all files are OK in cmp except ocean restart files on all platforms (except wcoss2). For wcoss2 answers are being changed.
(2) hafs_regional_storm_following_1nest_atm_ocn_wav_mom6: a bug fixing is included which changed answer in this PR
Input data Changes:
Library Changes/Upgrades:
Testing Log: