Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Networking issues master list #68

Open
3 tasks
adamgulde opened this issue Nov 17, 2024 · 0 comments
Open
3 tasks

Networking issues master list #68

adamgulde opened this issue Nov 17, 2024 · 0 comments
Labels
bug Something isn't working correctly or something crashes the program easy Good for newcomers medium Simple enough issue but probably overlooked during initial development. MVP Required for minimum viable product (ideal deadline: Dec. 11)

Comments

@adamgulde
Copy link
Collaborator

adamgulde commented Nov 17, 2024

  • When a player joins and disconnects at any time, this is not handled in banker.py

Steps to recreate:

  1. Run banker.py with some multi-player unittest. Run player.py for the appropriate number of players, without -debug arg
  2. As the player not in the gameboard, ctrl-c or type exit (this will terminate the python runtime.
  3. When it gets to be that player's turn, banker will crash.
  • When a player inputs the correct IP address but incorrect port, or some other combinations during initialize.py, it causes them to be unable to join even when the correct pair is input. They have to restart the python file to correctly join

Steps to recreate:

  1. Run banker.py with some multi-player unittest
  2. Run player.py without debug arg
  3. For enter host IP: enter a string instead of the correctly formatted IP address (xxx.xxx.xxx.xxx) [where x is an integer 0-9]
  4. Enter the correct host port
  5. You should see:
    Connection failed. Type 'exit' to quit or press enter to try again.
  6. Press enter
  7. Input the correct IP and port #
  8. Press enter when clients have joined. You should see
    [WinError 10057] A request to send or receive data was disallowed because the socket is not connected and (when sending on a datagram socket using a sendto call) no address was supplied Handshake failed. Type 'exit' to quit or press enter to try again.

Additionally, this can occur with the incorrect port, or slightly incorrect strings. Better handling of the initialize function is needed.

@adamgulde adamgulde added bug Something isn't working correctly or something crashes the program easy Good for newcomers medium Simple enough issue but probably overlooked during initial development. MVP Required for minimum viable product (ideal deadline: Dec. 11) labels Nov 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working correctly or something crashes the program easy Good for newcomers medium Simple enough issue but probably overlooked during initial development. MVP Required for minimum viable product (ideal deadline: Dec. 11)
Projects
None yet
Development

No branches or pull requests

1 participant