Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Contact form submit button displaying incorrect text #185

Closed
zeim839 opened this issue Nov 1, 2023 · 3 comments
Closed

Bug: Contact form submit button displaying incorrect text #185

zeim839 opened this issue Nov 1, 2023 · 3 comments
Assignees
Labels
bug/error Something isn't working difficulty: easy An easy issue good first issue Good for newcomers help wanted Extra attention is needed low priority low priority

Comments

@zeim839
Copy link
Collaborator

zeim839 commented Nov 1, 2023

Screenshot 2023-11-01 at 15 51 45

Image: See https://ufosc.org
(scroll to bottom)

The default value of the contact form 'submit' button varies between different browsers and devices, whereas we expect it to always be "submit". Sometimes, it will show up as "submit query", which is too large to fit within the button.

Solution: add a 'value' attribute to the input element in views/index.ejs at line 226. For example:

<input type="submit" name="submit" value="submit" class="contact__content__form-sumbit" style="background-color: #38F521;">
@zeim839 zeim839 added bug/error Something isn't working good first issue Good for newcomers help wanted Extra attention is needed low priority low priority difficulty: easy An easy issue labels Nov 1, 2023
@ChowChunLeong
Copy link

this task can assign to me?

@zeim839
Copy link
Collaborator Author

zeim839 commented Nov 2, 2023

@ChowChunLeong Sure. Let me know if you need any help.

@zeim839
Copy link
Collaborator Author

zeim839 commented Nov 2, 2023

Implemented in #186
Thanks @ChowChunLeong

@zeim839 zeim839 closed this as completed Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug/error Something isn't working difficulty: easy An easy issue good first issue Good for newcomers help wanted Extra attention is needed low priority low priority
Projects
None yet
Development

No branches or pull requests

2 participants