Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move pre-commit CI checking from pre-commit.ci to self-hosted runners #1296

Closed
cbrxyz opened this issue Oct 21, 2024 · 1 comment
Closed

Move pre-commit CI checking from pre-commit.ci to self-hosted runners #1296

cbrxyz opened this issue Oct 21, 2024 · 1 comment
Labels
ci difficulty: moderate software

Comments

@cbrxyz
Copy link
Member

cbrxyz commented Oct 21, 2024

What needs to change?

When Python 3.8 went EOL, pre-commit.ci removed support for running pre-commit with a default language version of python3.8. Since Python 3.8 is the default on 20.04, we want to continue using this distribution until we move to ROS 2 soon. Therefore, we will need to run pre-commit in our self-hosted CI runners in the future.

How would this task be tested?

  1. Ensure that pre-commit is able to be run in CI and that pre-commit.ci is no longer being used
@cbrxyz
Copy link
Member Author

cbrxyz commented Oct 25, 2024

Completed in 3f47c82

@cbrxyz cbrxyz closed this as completed Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
ci difficulty: moderate software
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@cbrxyz