Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Self Check Improvements #208

Open
2 of 5 tasks
duggerdufl opened this issue Apr 3, 2017 · 9 comments
Open
2 of 5 tasks

Self Check Improvements #208

duggerdufl opened this issue Apr 3, 2017 · 9 comments

Comments

@duggerdufl
Copy link
Member

duggerdufl commented Apr 3, 2017

  • Add an indication of which thrusters are not detected.
  • Check lsusb to detect if the cameras are plugged in vs the cameras launch not running.
  • Detect peripheral devices like the actuator box and the passive sonar (if they respond to a RS485 ping).
  • Check fps for all camera topics
  • Checking for degenerate thruster configurations
@DSsoto
Copy link
Member

DSsoto commented Apr 3, 2017

I would like to have a tool to automatically spin each thruster in sequence to confirm that they are indexed correctly and spinning in the right direction.

I'm currently looking at @jpanikulam's attempts at something like this.

@duggerdufl
Copy link
Member Author

That's a good idea. Would save time when we have problems or have to change out a thruster.

@sentree
Copy link
Member

sentree commented Apr 4, 2017

It would be fairly straight forward to write an RQT plugin for this.

@duggerdufl
Copy link
Member Author

What's the advantage of a RQT plugin over just a text based tool?

@sentree
Copy link
Member

sentree commented Apr 5, 2017

I didn't realize this was just a request to the existing system, sorry. It should be pretty simple to set ROS parameters for the path to each device in /dev and check if the file exists from Python.

@sentree
Copy link
Member

sentree commented Apr 9, 2017

@DSsoto suggested creating alarms so that we are notified of any changes.

DSsoto added a commit to DSsoto/SubjuGator that referenced this issue Apr 16, 2017
Also makes self check return the name of lost thrusters (uf-mil#208)
DSsoto added a commit to DSsoto/SubjuGator that referenced this issue Apr 16, 2017
Addresses part of issue uf-mil#208, RS485 checks still need to be done for
other peripheral devices
DSsoto added a commit to DSsoto/SubjuGator that referenced this issue Apr 16, 2017
Also makes self check return the name of lost thrusters (uf-mil#208)
DSsoto added a commit to DSsoto/SubjuGator that referenced this issue Apr 16, 2017
Addresses part of issue uf-mil#208, RS485 checks still need to be done for
other peripheral devices
DSsoto added a commit to DSsoto/SubjuGator that referenced this issue Apr 16, 2017
Also makes self check return the name of lost thrusters (uf-mil#208)
DSsoto added a commit to DSsoto/SubjuGator that referenced this issue Apr 16, 2017
Addresses part of issue uf-mil#208, RS485 checks still need to be done for
other peripheral devices
@DSsoto
Copy link
Member

DSsoto commented Apr 16, 2017

I addressed the 2 first points @duggerd made and also created the thruster_spin_test utility, Some of these diagnostic tests should be reported to the alarm server though, I will put that on the back burner.

BTW, should we make the self_check run automatically when we launch the sub? Thoughts?

@sentree
Copy link
Member

sentree commented Apr 16, 2017

As long as the sub is still in a totally inert and killed state for the test, this is fine. I don't want Ken getting any thruster surprises if someone forgets that this is a default launch behavior.

mattlangford pushed a commit that referenced this issue Apr 17, 2017
Also makes self check return the name of lost thrusters (#208)
mattlangford pushed a commit that referenced this issue Apr 17, 2017
Addresses part of issue #208, RS485 checks still need to be done for
other peripheral devices
@DSsoto
Copy link
Member

DSsoto commented May 15, 2017

We should also add to the self check:

Modified @duggerd's initial post so we can track progress from the issues tab

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants