Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove packages migrated to mil_common #205

Closed
DSsoto opened this issue Apr 3, 2017 · 5 comments
Closed

Remove packages migrated to mil_common #205

DSsoto opened this issue Apr 3, 2017 · 5 comments

Comments

@DSsoto
Copy link
Member

DSsoto commented Apr 3, 2017

We should start removing duplicate packages in the repo.

This is some of what needs to go:

  • sub8_perception/*/sub8_vision_lib
  • sub8_sonar
  • hydrophones
  • paulboard
  • some of sub8_tools
  • some of sub8_msgs

Be sure to reference your PR if you do any of this and/or add to this list.

@sentree
Copy link
Member

sentree commented Apr 4, 2017

Is taking care of this on NaviGator right now out of the question? I feel like if we don't it will be a mess to do next year.

@sentree
Copy link
Member

sentree commented Apr 4, 2017

Also, I would advise that we merge mil_common #15 before this.

@DSsoto
Copy link
Member Author

DSsoto commented Apr 4, 2017

Only if it's a low effort thing, we don't want to sink a lot of time into making NaviGator compatible right now.

Have you even reviewed any of it or commented that it looks good? No one has.

@kev-the-dev
Copy link
Contributor

kev-the-dev commented Apr 9, 2017

I'm going to make this my pet project for the week. Plan is as follows:

  1. Remove packages/files duplicated in mil_common
  2. Use git grep with awk to replace strings like 'sub8_ros_tools' with 'mil_ros_tools'
  3. Look at diff to verify nothing crazy happened
  4. Start testing things to see what's broken

I'll open a PR once I get to step 4 to see if anyone notices anything wacky.

@sentree
Copy link
Member

sentree commented Apr 13, 2017

Can this be closed now that #216 has been merged?

@DSsoto DSsoto closed this as completed Apr 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants