shadcx does not respect alias field

[yf-yang]

Description

When designating aliases.ui, shadcx still add component to components/plate-ui folder

My components.json:

{
  "$schema": "https://ui.shadcn.com/schema.json",
  "style": "default",
  "rsc": true,
  "tsx": true,
  "tailwind": {
    "config": "tailwind.config.ts",
    "css": "src/index.css",
    "baseColor": "slate",
    "cssVariables": true,
    "prefix": ""
  },
  "iconLibrary": "react-icons/lu",
  "aliases": {
    "components": "@/components",
    "utils": "@udecode/cn",
    "plate-ui": "@/components/plateUi",
    "ui": "@/components/shadcnUi"
  },
  "registries": {
    "plate": {
      "aliases": {
        "ui": "@/components/plateUi",
        "plate-ui": "@/components/plateUi"
      },
      "url": "https://platejs.org/r"
    }
  }
}

I've specified multiple combinations of "alias" and "plate-ui", but

pnpm shadcx add plate/resizable
✔ Checking registry.
✔ Installing dependencies.
✔ Created 1 file:
  - src/components/plate-ui/resizable.tsx

Reproduction URL

No response

Reproduction steps

Check description

Plate version

[email protected]

Slate React version

Unrelated

Screenshots

No response

Logs

No response

Browsers

No response

[yf-yang]

Investigation:

plate/packages/cli/src/utils/updaters/update-files.ts

Lines 74 to 81 in 6fad759

	let targetDir = getRegistryItemFileTargetPath(file, config);
	const fileName = basename(file.path);
	let filePath = path.join(targetDir, fileName);
	if (file.target) {
	filePath = resolveTargetDir(projectInfo, config, file.target);
	targetDir = path.dirname(filePath);
	}

Line 74, the path is resolved to registries.plate.aliases.ui

Line 78, it is overridden by the component's config

Sample file:

plate/apps/www/public/r/styles/default/resizable.json

Line 24 in 6fad759

"target": "components/plate-ui/resizable.tsx",

[zbeyens]

Does it work with shadcn? If so, can you spot the code diff?

[yf-yang]

I checked shadcn's source code, it seems they are completely different?

[yf-yang]

I see, let me confirm how shadcn works. It does work with shadcn.

[zbeyens]

shadcx should only be an extension of shadcn. We regularly sync with the latest version of shadcn, but we may have missed edge cases

[yf-yang]

I'm confused, shadcx's cli code is completely different from shadcn's. Is it copied from shadcn repository at some time before?

[yf-yang]

With "registries", shadcn does not recognize components.json, too. I guess they validate the schema

[zbeyens]

shadcn-ui/ui#5963

[yf-yang]

My bad 🤣. I check shadcn's cli package and didn't see related codes. Now I realize its the shadcn package. I'll compare them later