Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Statistics Pattern Bounding Box #348

Open
Herm71 opened this issue Aug 6, 2024 · 2 comments
Open

Statistics Pattern Bounding Box #348

Herm71 opened this issue Aug 6, 2024 · 2 comments
Assignees
Labels
bug Something isn't working will-not-fix This will not be worked on

Comments

@Herm71
Copy link
Member

Herm71 commented Aug 6, 2024

The Statistics Pattern has a group-within a group.
The inner group is "pushed up" into the cover block above it with a transform rule.

.ucsc__statistics-content {
    position: relative;
    transform: translateY(calc(var(--wp--preset--spacing--70)*-1));
    z-index: 1;
}

When this is done, the outer group's bounding box stays the same, resulting in considerable white space between this whole pattern and the content that comes below it.

Examples

Editor:
editor-statistics-block

Front-end:
stats-pattern-front

@Herm71 Herm71 added the bug Something isn't working label Aug 6, 2024
@Herm71 Herm71 added the will-not-fix This will not be worked on label Jan 2, 2025
@Herm71
Copy link
Member Author

Herm71 commented Jan 2, 2025

This issue is fixed with the release of WP 6.7, which implements negative margins. Using negative margins when building content using core blocks will enable users to approximate the affect of this custom pattern.

@Herm71 Herm71 closed this as completed Jan 2, 2025
@knice
Copy link
Member

knice commented Jan 6, 2025

Re-opening this issue. We will look into using negative margins (now supported in the WordPress block editor UI as of 6.7.1) to recreate the overlap of the statistics grid on top of the layer above it.

@knice knice reopened this Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working will-not-fix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants