Popup Restyling #191
Closed
Popup Restyling #191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: * Added max height of popup, so scrollbar appears when content exceeds max * Added URL wraparound (no overflow) * Slightly rearranged components for better visual appeal (e.g. made recording separate section from slides)
Aplet123
reviewed
Jun 26, 2024
pages/archive.tsx
Outdated
| @@ -156,7 +156,7 @@ const PopUp = ({ event, close }: { event: CyaneaEvent; close: () => void }) => { | |||
| <div className={popUpStyle["date"]}>{formatEventDate(event)}</div> | |||
| <div className={popUpStyle["location"]}>{event.location}</div> | |||
| <div className={styles.tags}> | |||
| <span>Tags: </span> | |||
| <div>Tags:</div> | |||
There was a problem hiding this comment.
Is there a reason this isn't a <div><span>?
There was a problem hiding this comment.
Not really. Just changed it to a <div><span>.
There was a problem hiding this comment.
I think @Aplet123 was trying to say that i should be <div className=...><span> rather than changing the inner <div> to a <div> + <span>, @stewartkwokca.
There was a problem hiding this comment.
Ah, maybe I'm confused but I don't think the span ever had any classes before? I just wanted to move it onto its own line to be consistent with everything else. Which classes were I supposed to include?
There was a problem hiding this comment.
Will work on cards a little more first
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: popup cards
Closes #180
Fixed horizontal URL overflow (removed horizontal scroll bars)
Added vertical scrollbar for long cards
Fixed extreme graphic cutoffs (now fit to card)
Small component rearrangement