Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

blank lines printed by postprocess.py #24

Open
jdherman opened this issue Oct 26, 2016 · 7 comments
Open

blank lines printed by postprocess.py #24

jdherman opened this issue Oct 26, 2016 · 7 comments

Comments

@jdherman
Copy link
Collaborator

First referenced in #23 which is now closed.

@mfefer @msdogan use this issue to track when/where this seems to be happening. Maybe some data isn't being filled into the dictionaries properly.

This may be fixed by Max's latest changes to postprocess.py which he's going to work on a pull request for.

@msdogan
Copy link
Member

msdogan commented Oct 26, 2016

@jdherman these blank lines were also happening while I was writing networkcheck.py results into csv. Now, we don't use it anymore.

https://github.com/msdogan/pyvin/blob/master/preprocessor/networkcheck.py

# # Save results to a .csv file
# nodes = [node[0] for node in nodes]
# with open('networkcheck.csv', 'w') as csvfile:
#     writer = csv.writer(csvfile, delimiter=',')
#     writer.writerow(["node", "# incoming", "# outgoing"]) # header
#     writer.writerows(zip(nodes, list(incoming), list(outgoing))) # results

@jdherman
Copy link
Collaborator Author

Ok. I'm not looking into this right now, but let's keep the issue open in case it becomes a problem later with postprocess.py.

@msdogan
Copy link
Member

msdogan commented Nov 2, 2016

I am assuming latest pull request https://github.com/m.pysdogan/pyvin/pull/27 resolved blank line issue in postprocess.py output csv.

@jdherman
Copy link
Collaborator Author

jdherman commented Nov 2, 2016

I didn't do anything specific to resolve it, but I didn't notice any problems with blank lines.

@msdogan
Copy link
Member

msdogan commented Nov 11, 2016

This is not urgent but I am just curious if I am the only one to get blank lines when running postprocess.py My data and result file is attached. (I updated my repository)
pyvin_1_year_11102016.zip

@msdogan
Copy link
Member

msdogan commented Nov 11, 2016

Update: when I run this on my laptop, I didn't get blank lines. It can be python 3 - 2.7 thing.

@jdherman
Copy link
Collaborator Author

tested with python 2 & 3 and I can't seem to reproduce the problem.

might be a windows / line ending problem? we'll have to keep an eye on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants