Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Add test and support for links with nested ()s #657

Open
1 task done
jimbonothing64 opened this issue Apr 18, 2024 · 1 comment · May be fixed by #658
Open
1 task done

[Bug]: Add test and support for links with nested ()s #657

jimbonothing64 opened this issue Apr 18, 2024 · 1 comment · May be fixed by #658
Labels

Comments

@jimbonothing64
Copy link
Contributor

jimbonothing64 commented Apr 18, 2024

Description of the bug

Bug

Links with ()s do not parse correctly. See uccser/cs-field-guide#2565 (Thanks to @mckzm for spotting this and working on a fix!)

Proposed fix

  • Update python-markdown to 3.0 or greater.
  • Add a test, with link https://en.wikipedia.org/wiki/Entropy_(information_theory)

Background

In uccser/cs-field-guide#2566, the problem links were enclosed in <>, as per Common mark spec. But pyton-markdown uses John Gruber's Spec, which does not support enclosing links in <>.

Using a newer version of python-markdown should fix these problem links, and still conformant to the John Gruber's Spec.

See blame for date fix was added to python-markdown:
https://github.com/Python-Markdown/markdown/blame/7c382f6c5d438d6d6661f842b03f15dbd6e42a2d/markdown/inlinepatterns.py#L449

Steps To Reproduce

Include [Entropy and information theory](https://en.wikipedia.org/wiki/Entropy_(information_theory)) in a template a markdown file and then render it using verto.

What device/software are you seeing this problem on?

No response

Additional Information

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@jimbonothing64
Copy link
Contributor Author

Updating to markdown 3.0 does not fix parsing for [Entropy and information theory](https://en.wikipedia.org/wiki/Entropy_(information_theory)). Updating further than 3.0 causes more issues; no immediate action.

@jimbonothing64 jimbonothing64 changed the title [Bug]: Add test and support for links with nested ()s by updating python-markdown to 3.0 or greater [Bug]: Add test and support for links with nested ()s Apr 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging a pull request may close this issue.

1 participant