fix: use login1 dbus API, fix systemd-run #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gerblesh
force-pushed
the
dbus-list-user
branch
from
1ca8175 to
14b9a7a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR supersedes: #133
session.pynow uses the dbus API instead of using loginctl subprocess, instead using busctl as a subprocess, this can however be migrated to dbus-python easily. The dbus API is also hopefully more stable than the loginctl CLI, though we are still using busctl.This also fixes an issue with update confirmation, where output wasn't probably being piped back into stdout when using
systemd-run, meaning that update confirmations were impossible andublue-updatewould error instead of update when confirming