feat: use systemd-run, fix topgrade #130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gerblesh
force-pushed
the
systemd-run-fix-topgrade
branch
from
1afc097 to
c1ea112
Compare
gerblesh
changed the title
gerblesh
force-pushed
the
systemd-run-fix-topgrade
branch
from
3e8401c to
e1e88eb
Compare
|
tested on my end, and everything works just the same! Ready to be merged, just need another set of eyes on it |
|
May I ask if the release action failure can be fixed in some way? I would greatly appreciate it if there can be a release with this fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR switches from using
sudoto handle multi-user to usingsystemd-run, allowing us to have a much easier time diagnosing problems, and not have to hack in environment variables. This PR also includes a fix for the issue: #113 where topgrade prompts for breaking changes