Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some bugs and perform improvements #366

Open
EresDev opened this issue Dec 30, 2024 · 2 comments · May be fixed by #367
Open

Fix some bugs and perform improvements #366

EresDev opened this issue Dec 30, 2024 · 2 comments · May be fixed by #367

Comments

@EresDev
Copy link
Contributor

EresDev commented Dec 30, 2024

Some ideas that I hope will make the product more reliable, stable, easy to deploy and configure.

Improvements

  • Add a way to test cards in pull request. Currently 0$ permit will never give you a card to test in PR because no card is available at 0$.
  • reduce duplication. use non secret vars like treasury, reward token from .env vars and push them to cloudflare during deployment. Maybe even push secrets to cloudflare from github and keep all secrets in github. There should not be a need to add vars and secrets in cloudflare manually. I think this is how kernel works and this should too.
  • improve folder structure, move all configs to one /configs folder.
  • enforce yarn version in package.json (let's try this at least in this repository i think it will be helpful.)
  • add some text indicating reloadly sandbox if the page is using reloadly sandbox
  • add a way for developers to work on frontend only without worrying about or configuring much of the backend. I think this is possible by changing the base-url in frontend.
  • ask for user's name on card minting, as it is required field in Reloadly docs, but somehow it still works without name. It will be a good idea to include it.
  • Do not ask user to change their rpc on metamask. Only ask user to change network if user is on the wrong network. If their rpc is down, just tell the user the rpc is down. Changing their RPC seems too invasive to me. Current code did this several times to me even though the official RPC was working fine.

Bugs

  • undefined error when wallet is connected, but not signed in. sometime it doesn't show up. more likely to show up on a new permit link.
    image
  • this is not a unknown error but a more common error. should show limited info.
    image
@EresDev
Copy link
Contributor Author

EresDev commented Dec 30, 2024

Estimated 2-3 days. I hope I have labeled time correctly.

@EresDev
Copy link
Contributor Author

EresDev commented Jan 1, 2025

/start

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

Successfully merging a pull request may close this issue.

2 participants