-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: decode metamask transaction error #353
base: development
Are you sure you want to change the base?
Conversation
|
Looks good. Idk if it's worth it to also log the onchain function name that was called too using the 4byte api .. @rndquu rfc I think if we can make this robust and re-useable @ariesgun then we can open a task and implement it in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This QA has some drawbacks:
- Result is shown in the console instead of a toaster
- Error is not in a human readable way
Expected behavior: user sees a toaster with a human friendly error instead of a hex string.
Pls use https://github.com/superical/ethers-decode-error/tree/1.x, I'm sure we can simply fork it and set node version to <20
.
It should be made clear in the spec. |
Unused dependencies (1)
Unlisted dependencies (2)
|
For now, waiting for the ubiquite-hosted npm package for |
I opened a PR on that regard here: ubiquity/ethers-decode-error#1 |
I suppose all crypto related software should be under ubiquity org. |
@ariesgun, this task has been idle for a while. Please provide an update. |
Still ongoing |
@ariesgun, this task has been idle for a while. Please provide an update. |
I had implemented our own @ariesgun Did you manually publish it? If so I do not have the |
yes, I did it manually |
@ariesgun, this task has been idle for a while. Please provide an update. |
Still waiting for the package to be uploaded |
@0x4007 You are the one with |
Isn't NPM_TOKEN relevant? The latest release workflow silently failed with |
@rndquu yeah I tried several times: Either we should change the workflow, either manually publish because it seems to compare the version to the main forked repo so we cannot make any modification and publish it. We could copy the publishing action we usually use for our other projects. |
@ariesgun, this task has been idle for a while. Please provide an update. |
Is there anything I can do to finalize this PR? As far as I understand, the package has not been uploaded yet due to token issue? |
I published it under @rndquu You can delete this repo: https://github.com/ubiquity/ethers-decode-error thank you. |
The crypto related stuff should be under @ubiquity |
@0x4007 Please move it because I have no access and the NPM token under |
That's right we might not have access to the ubiquity npm for some reason. @rndquu im mobile but do you have access? Can you solve for this |
Is there anything I can do to help close this one? |
@rndquu @gentlementlegen lets finalize this |
@0x4007 would need the token to be updated in order to publish to the proper NPM organization. |
As far as I understand everything is fine right now:
|
Resolves #346