Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redact switch #23

Open
0x4007 opened this issue Sep 30, 2024 · 22 comments
Open

Redact switch #23

0x4007 opened this issue Sep 30, 2024 · 22 comments

Comments

@0x4007
Copy link
Member

0x4007 commented Sep 30, 2024

Config to toggle redacts.

Used for private repos only.

redactPrivateRepoComments: boolean

Default we capture everything.

Maybe we shouldn't redact comments in the near future. And instead have a switch for it later when/if partners ever ask. I feel like most people won't care and it will give us more data to work with for research purposes in the near future.

I guess it would be fine to have it as an option in the configuration, because as long as not everybody can access the DB the content of private repositories cannot be read by outsiders.

Originally posted by @gentlementlegen in #20 (comment)

Copy link
Contributor

ubiquity-os bot commented Oct 1, 2024

! Fetching all pull requests failed!

@shiv810
Copy link
Collaborator

shiv810 commented Oct 1, 2024

I think this task is overpaid, this is a simple fix. @0x4007

@shiv810
Copy link
Collaborator

shiv810 commented Oct 1, 2024

/start

Copy link
Contributor

ubiquity-os bot commented Oct 2, 2024

@sshivaditya2019 the deadline is at Wed, Oct 2, 2:06 PM UTC

Copy link

Note

The following contributors may be suitable for this task:

gentlementlegen

0% Match ubiquity-os-marketplace/text-conversation-rewards#135

@0x4007 0x4007 added good first issue Good for newcomers and removed good first issue Good for newcomers labels Dec 12, 2024
@Sadaf-A
Copy link

Sadaf-A commented Dec 20, 2024

/start

Copy link

! You do not have the adequate role to start this task (your role is: member). Allowed roles are: collaborator, admin.

@koya0
Copy link

koya0 commented Jan 13, 2025

/start

Copy link

! You must be a core team member, or an administrator to start this task

@0x4007
Copy link
Member Author

0x4007 commented Jan 14, 2025

> ```diff
> ! You must be a core team member, or an administrator to start this task
> ```
> 
> <!-- UbiquityOS - checkRequirements - CLOUDFLARE_VERSION_METADATA - @koya0 - https://dash.cloudflare.com/<missing-cloudflare-account-id>/workers/services/view/ubiquity-os-command-start-stop-development/production/observability/logs?granularity=0&time=%7B%22type%22%3A%22absolute%22%2C%22to%22%3A1736803182734%2C%22from%22%3A1736803062734%7D
> {
>   "caller": "checkRequirements"
> }
> -->
> 

@gentlementlegen Metadata is missing some values.

I also think we can shorten the message to "You must be a core team member to start this task"

missing-cloudflare-account-id

@gentlementlegen
Copy link
Member

gentlementlegen commented Jan 14, 2025

The CLOUDFLARE_VERSION_METADATA and CLOUDFLARE_VERSION_ID need to be set during deployment and is probably missing from the deploy_worker.yml script and wrangler.toml in this plugin.

I added the administrator in the message because technically some task can be admin only (even collaborators can't start it) or contributor only, even if it is an unlikely scenario.

Create a related issue: #68

@0x4007
Copy link
Member Author

0x4007 commented Jan 14, 2025

If they are an admin it is implied that they are a core team member. You can make a dedicated admin only one as well then.

@gentlementlegen
Copy link
Member

Admin is a core team member, but a core team member is not an admin. You can also have outside contributors that are admin of certain repositories.

The text is dynamic and will display:

  • "administrator"
  • "core team member"
  • "contributor"

and combine these according to the settings. Example: "You must be an administrator to start this task" if admin only, or "You must be a core team member, or an administrator to start this task" such as here when contributors + admins are allowed

@0x4007
Copy link
Member Author

0x4007 commented Jan 14, 2025

I understand. Still, the only two messages should be:

"You must be an admin to start this task"

Or

"You must be a core team member to start this task"

@gentlementlegen
Copy link
Member

@0x4007 Sure, but technically we do support "contributor only" scenario in the configuration. Shall this be removed?

@0x4007
Copy link
Member Author

0x4007 commented Jan 14, 2025

Yes admins always should have full access.

@gentlementlegen
Copy link
Member

@0x4007 Admins always have full access, I meant when only contributor (outsiders) are allowed to start task, I can remove this feature but then I should change the configuration again because there would be only one option in the allowed roles (contributors).

@0x4007
Copy link
Member Author

0x4007 commented Jan 14, 2025

I think that's not useful either way because self assignment with the UI is possible for collaborators.

Also permissions should be like a pyramid.

Admin at top, with all permissions on the below roles.

Then collaborators should have all permissions of below.

Contributors.

@koya0
Copy link

koya0 commented Jan 15, 2025

/start

Copy link

! You must be a core team member, or an administrator to start this task

@gentlementlegen
Copy link
Member

@koya0 priority 3 and higher are usually only for core team members. Also, you will hit a task assignment limit if you do not solve the tasks you are assigned to.

@koya0
Copy link

koya0 commented Jan 15, 2025

@koya0 priority 3 and higher are usually only for core team members. Also, you will hit a task assignment limit if you do not solve the tasks you are assigned to.

sorry, I only tried again because you said that the repos of the org were missing something in the config, so I thought that maybe I could be assigned when you fixed it 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants