-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Redact switch #23
Comments
! Fetching all pull requests failed! |
I think this task is overpaid, this is a simple fix. @0x4007 |
/start |
@sshivaditya2019 the deadline is at Wed, Oct 2, 2:06 PM UTC |
Note The following contributors may be suitable for this task: gentlementlegen
|
/start |
! You do not have the adequate role to start this task (your role is: member). Allowed roles are: collaborator, admin. |
/start |
! You must be a core team member, or an administrator to start this task |
@gentlementlegen Metadata is missing some values. I also think we can shorten the message to "You must be a core team member to start this task"
|
The I added the Create a related issue: #68 |
If they are an admin it is implied that they are a core team member. You can make a dedicated admin only one as well then. |
Admin is a core team member, but a core team member is not an admin. You can also have outside contributors that are admin of certain repositories. The text is dynamic and will display:
and combine these according to the settings. Example: "You must be an administrator to start this task" if admin only, or "You must be a core team member, or an administrator to start this task" such as here when contributors + admins are allowed |
I understand. Still, the only two messages should be: "You must be an admin to start this task" Or "You must be a core team member to start this task" |
@0x4007 Sure, but technically we do support "contributor only" scenario in the configuration. Shall this be removed? |
Yes admins always should have full access. |
@0x4007 Admins always have full access, I meant when only contributor (outsiders) are allowed to start task, I can remove this feature but then I should change the configuration again because there would be only one option in the allowed roles (contributors). |
I think that's not useful either way because self assignment with the UI is possible for collaborators. Also permissions should be like a pyramid. Admin at top, with all permissions on the below roles. Then collaborators should have all permissions of below. Contributors. |
/start |
! You must be a core team member, or an administrator to start this task |
@koya0 priority 3 and higher are usually only for core team members. Also, you will hit a task assignment limit if you do not solve the tasks you are assigned to. |
sorry, I only tried again because you said that the repos of the org were missing something in the config, so I thought that maybe I could be assigned when you fixed it 😅 |
Config to toggle redacts.
Used for private repos only.
redactPrivateRepoComments: boolean
Default we capture everything.
I guess it would be fine to have it as an option in the configuration, because as long as not everybody can access the DB the content of private repositories cannot be read by outsiders.
Originally posted by @gentlementlegen in #20 (comment)
The text was updated successfully, but these errors were encountered: