Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ignore hv cell #506

Merged
merged 1 commit into from
Nov 9, 2023
Merged

ignore hv cell #506

merged 1 commit into from
Nov 9, 2023

Conversation

samjrholt
Copy link
Member

@samjrholt samjrholt commented Nov 9, 2023

One cell in the field holoviews plotting started failing with Python 3.10 (no obvious error, probably some sort of change in the format). As a workaround we ignore that cell.

Copy link
Contributor

github-actions bot commented Nov 9, 2023

PR Analysis

  • 🎯 Main theme: Ignoring a specific cell
  • 📝 PR summary: The PR seems to be about ignoring a specific cell, but without further context or code changes, it's hard to provide a detailed summary.
  • 📌 Type of PR: Other
  • 🧪 Relevant tests added: No
  • ⏱️ Estimated effort to review [1-5]: 1, because there are no code changes in the PR.
  • 🔒 Security concerns: No security concerns found

PR Feedback

  • 💡 General suggestions: It seems like there are no code changes in this PR. Please ensure that the changes you intended to make have been correctly committed and pushed to the branch.

  • 🤖 Code feedback:

How to use

To invoke the PR-Agent, add a comment using one of the following commands:
/review [-i]: Request a review of your Pull Request. For an incremental review, which only considers changes since the last review, include the '-i' option.
/describe: Modify the PR title and description based on the contents of the PR.
/improve [--extended]: Suggest improvements to the code in the PR. Extended mode employs several calls, and provides a more thorough feedback.
/ask <QUESTION>: Pose a question about the PR.
/update_changelog: Update the changelog based on the PR's contents.

To edit any configuration parameter from configuration.toml, add --config_path=new_value
For example: /review --pr_reviewer.extra_instructions="focus on the file: ..."
To list the possible configuration parameters, use the /config command.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ee6c029) 93.49% compared to head (0fdd75d) 93.49%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #506   +/-   ##
=======================================
  Coverage   93.49%   93.49%           
=======================================
  Files          28       28           
  Lines        3027     3027           
=======================================
  Hits         2830     2830           
  Misses        197      197           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@samjrholt samjrholt requested a review from lang-m November 9, 2023 13:06
@samjrholt
Copy link
Member Author

@lang-m this has fixed the issue. Please merge and update the latest tag if you are happy.

@lang-m lang-m merged commit a828938 into master Nov 9, 2023
7 checks passed
@lang-m lang-m deleted the hv_python310 branch November 9, 2023 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants