Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-activate pre-commit checks #496

Closed
lang-m opened this issue Sep 29, 2023 · 1 comment
Closed

Re-activate pre-commit checks #496

lang-m opened this issue Sep 29, 2023 · 1 comment

Comments

@lang-m
Copy link
Member

lang-m commented Sep 29, 2023

Temporarily disabled because they keep failing with an error that does not make sense (complaining about re-definition of a function that is not actually re-defined). Looks a bit like there was some sort of caching/lack of cache cleaning going on so that we end up with a mixture of different versions of one file when running the pre-commit checks.

@samjrholt and I individually had a look and both tested it locally. There does not seem to be a problem in the code and the pre-commits pass locally.

I hope that maybe disabling and re-enabling later might "magically" fix the problem.

@lang-m
Copy link
Member Author

lang-m commented Oct 6, 2023

Done

@lang-m lang-m closed this as completed Oct 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant