Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move example-gateway to a standalone example #383

Open
ChuntaoLu opened this issue May 10, 2018 · 2 comments
Open

Move example-gateway to a standalone example #383

ChuntaoLu opened this issue May 10, 2018 · 2 comments

Comments

@ChuntaoLu
Copy link
Contributor

example-gateway is interleaved with Zanzibar and does not work as a standalone example. It should be a full-fledged standalone example.

@Raynos
Copy link
Contributor

Raynos commented May 14, 2018

its both used in the integration test suite as well as being an example.

I think a full-fledged example would be a good idea; but getting the integration test suite to work against HEAD ( especially uncommitted changes ) would be non-trivial without duplicating the example twice.

@Raynos
Copy link
Contributor

Raynos commented May 14, 2018

Whatever creative solution you come up ; we need an example that is tested on every commit of master. having an example that can be broken / stale because its not verified in travis/jenkins is more frustrating then not having an example at all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants