Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Errors on arg read/write should not block channel shutdown #723

Open
prashantv opened this issue Dec 5, 2018 · 0 comments
Open

Errors on arg read/write should not block channel shutdown #723

prashantv opened this issue Dec 5, 2018 · 0 comments

Comments

@prashantv
Copy link
Contributor

If a ArgReader is closed without reading all data, it returns an error:

r.err = errMoreDataInArgument

This does not close the underlying message exchange, so as far as the channel is concerned, there's a pending call. However, this pending call can never be cleared, since all further operations return the same error.

We should close the message exchange on any errors,

func (mex *messageExchange) shutdown() {

That will ensure that the channel close isn't blocked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant